Skip to content

Unanchor scales from 0 in free-scaled facets #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
teunbrand wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −5
Draft

Unanchor scales from 0 in free-scaled facets #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6194d21
also un-zero free panels
teunbrand May 1, 2026
c150634
add news bullet
teunbrand May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
## [Unreleased]

### Fixed

- Fixed bug where panel axes were unintentionally anchored to zero when using
`FACET ... SETTING free => 'x'/'y'` (#410).

## 0.3.1 - 2026-04-30

### Fixed
Expand Down
7 changes: 2 additions & 5 deletions src/writer/vegalite/encoding.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,11 +924,8 @@ fn build_column_encoding(

// Position scales don't include zero by default — but only when we set
// an explicit domain. With free facet scales (no domain), VL computes
// the domain from data values. Setting zero:false in that case can exclude
// 0 from the domain, breaking charts with pre-computed stacking (y2/theta2
// starts at 0). Let VL's defaults handle it instead.
Comment on lines -927 to -929
Copy link
Copy Markdown
Collaborator Author

@teunbrand teunbrand May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the pre-computed stacking problem described here, so I'm assuming it might've been passenger-fixed earlier.

let is_free = is_position_free_for_aesthetic(aesthetic, ctx.free_scales);
if aesthetic_ctx.is_primary_internal(aesthetic) && !is_free {
// the domain from data values.
if aesthetic_ctx.is_primary_internal(aesthetic) {
scale_obj.insert("zero".to_string(), json!(false));
}

Expand Down
Loading