Fix warnings for bakery and improve Pydantic usage#118
Merged
bschwedler merged 5 commits intomainfrom Feb 25, 2025
Merged
Conversation
…ator to throw back a Nonetype
- Change implicity Nonetypes to explicit - Utilize Annotated Field method for instantiating defaults for submodels
Test Results246 tests 244 ✅ 55s ⏱️ Results for commit 5f8569b. |
bschwedler
approved these changes
Feb 25, 2025
Contributor
bschwedler
left a comment
There was a problem hiding this comment.
Thank you for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes our pytest warnings from 94 to 0.
snyk monitorcalls without tags would cause the validator to throw back a Nonetype.base_urlto acomputed_fieldso it can be serialized. It's possible this should be done in additional places or that other models should have their calculated property fields excluded from serialization.