Summarize dgoss results after execution completes#123
Merged
ianpittwood merged 8 commits intomainfrom Mar 21, 2025
Merged
Conversation
Test Results301 tests 299 ✅ 1m 9s ⏱️ Results for commit 8be45c2. ♻️ This comment has been updated with latest results. |
Contributor
bschwedler
approved these changes
Mar 6, 2025
Contributor
|
It could be useful to include the list the skipped tests when the This also makes me think about whether we should break up the tests into sections or files that are included conditionally instead of peppering this everywhere |
Fix one more failing snyk test
Add test_failures retrieval property to GossJsonReportCollection
- Print summary of failed tests if there are failures - Print runtime errors if any commands fail to execute - If any tests or commands fail, exit 1
d8b76a0 to
5100d6f
Compare
- Show success in bold green if there are no failed tests. - Show failures in bold red if there are failures. Use bright black italics for zero. - Show skips in bold yellow if tests were skipped. Use bright black italics for zero. - Add a total tests column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #102
Follows #122
dgossresults in arich.Tableby image name, version, and type with the total test duration and number of successful, failed, and skipped tests.dgossraise, instead return them as part of a tuple with the test results.dgossexits non-zero, assume it's due to test failures if the command produced a valid JSON output.dgossexits non-zero and output cannot be parsed as JSON, consider the command to have experienced a runtime error. Create and collect aBakeryToolRuntimeErrorto return with the commmand.This approach has some shortcomings we'll need to consider:
gosscannot produce multiple result outputs. If we wish to allow other result outputs, we will need to heavily modify our implementation to expect a variety of different output formats or we will need to convert the JSON into other formats ourselves. I assume team's may want a more common standard reported back, such as JUnit, so we will need to consider how/if we want to perform that conversion or if we should just ignore summarizing results in the CLI.--quiet. We may want to consider if it should be.