Merged
Conversation
Test Results425 tests 425 ✅ 1m 24s ⏱️ Results for commit a117ed5. |
bschwedler
approved these changes
Sep 8, 2025
Contributor
bschwedler
left a comment
bschwedler
left a comment
There was a problem hiding this comment.
This PR is remarkably compact for all the work and logic it is doing.
My comments are only about readability/maintainability. The functionality looks great!
Comment on lines
+17
to
+18
| helper_test_collection = [ | ||
| *[ |
Contributor
There was a problem hiding this comment.
Using itertools.chain.from_iterable removes the need for arg unpacking.
Suggested change
| helper_test_collection = [ | |
| *[ | |
| helper_test_collection = itertools.chain.from_iterable([ | |
| [ |
Contributor
Author
There was a problem hiding this comment.
It does in theory, but I can't seem to get pytest to work with a lazy-loading set of params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from #143