Switch image variants to default to an empty list.#191
Merged
bschwedler merged 1 commit intomainfrom Sep 10, 2025
Merged
Conversation
bschwedler
commented
Sep 10, 2025
Test Results444 tests 444 ✅ 1m 23s ⏱️ Results for commit a020e3a. ♻️ This comment has been updated with latest results. |
bschwedler
force-pushed
the
variants-empty-default
branch
2 times, most recently
from
9addda9 to
93507e6
Compare
ianpittwood
approved these changes
Sep 10, 2025
Contributor
ianpittwood
left a comment
ianpittwood
left a comment
There was a problem hiding this comment.
I think this is all looking good. Just one small naming nit.
This behavior will be better for downstream usage of `bakery` This also means that the absence of the `variants` key means that the image has no variants.
bschwedler
force-pushed
the
variants-empty-default
branch
from
93507e6 to
a020e3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior will be better for downstream usage of
bakeryThis also means that the absence of the
variantskey means that theimage has no variants.