Change platform build option to be a filter#271
Merged
ianpittwood merged 10 commits intomainfrom Dec 17, 2025
Merged
Conversation
Test Results803 tests 803 ✅ 9m 8s ⏱️ Results for commit 69c8afd. ♻️ This comment has been updated with latest results. |
bschwedler
approved these changes
Dec 16, 2025
Comment on lines
+121
to
+122
| platforms: | ||
| - "linux/amd64" |
Contributor
There was a problem hiding this comment.
I think it could be useful to keep some OSes in this file to just get the default platform.
Is there a specific reason you were explicit with every entry in this file?
Contributor
Author
There was a problem hiding this comment.
Good idea, I'll do that.
Co-authored-by: Benjamin R. J. Schwedler <ben@posit.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #265
--platformto--image-platform.--image-platformfrom an override to a filter, similar to other options such as--image-nameor--image-os.--image-platformoption torun dgosscommand to selectively run against different build platforms. Note, only one can be provided at a time sincegossis not a universal binary. See Implement managed downloads of goss/dgoss #272 for a future fix idea.