Conversation
Render GossConfig.wait prior to validation since template strings will not evaluate as int
Test Results72 tests 72 ✅ 5s ⏱️ Results for commit 30c0c52. ♻️ This comment has been updated with latest results. |
|
Add some extra safeguards for empty manifests
Move `Manifest.generate_target_builds` to `TargetBuild.load`
bschwedler
approved these changes
Nov 21, 2024
Contributor
bschwedler
left a comment
bschwedler
left a comment
There was a problem hiding this comment.
@ianpittwood I am ready to merge this. I wanted you to be aware look at a couple small things before doing so.
We have created issues to address the CLI functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Brings coverage to ~86%