feat: add install_jupyterlab_workbench macros for Posit Workbench images#474
Merged
ianpittwood merged 4 commits intomainfrom Apr 23, 2026
Merged
feat: add install_jupyterlab_workbench macros for Posit Workbench images#474ianpittwood merged 4 commits intomainfrom
ianpittwood merged 4 commits intomainfrom
Conversation
bschwedler
approved these changes
Apr 23, 2026
ianpittwood
force-pushed
the
jupyterlab-vuln-path-strip-macros
branch
3 times, most recently
from
9b06243 to
ab1b381
Compare
Adds `install_jupyterlab_workbench` and `run_install_jupyterlab_workbench` macros to `python.j2` for installing JupyterLab, notebook, and pwb_jupyterlab into a dedicated virtual environment, symlinking `jupyter` onto the system PATH, and optionally stripping the JupyterLab tests directory and staging yarn.lock from the installed venv. Supports configurable venv name, jupyterlab/pwb_jupyterlab version pins, and extra packages. Includes tests covering defaults, version pins, extra packages, custom venv name, strip toggles, and the RUN wrapper. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Also update test expectations to match recent macro changes (quoted jupyterlab/pwb_jupyterlab packages, removal of --break-system-packages, and bare rm lines in place of bash -O failglob wrappers). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ianpittwood
force-pushed
the
jupyterlab-vuln-path-strip-macros
branch
from
ab1b381 to
209d0f4
Compare
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_jupyterlab_workbenchandrun_install_jupyterlab_workbenchmacros toposit-bakery/posit_bakery/config/templating/macros/python.j2/opt/python/{jupyter_venv_name}, installsjupyterlab/notebook/pwb_jupyterlabinto it, and symlinksjupyteronto the system PATHjupyter_venv_name,jupyterlab_version_pin,pwb_jupyterlab_version_pin,extra_packages, andstrip_tests/strip_stagingtoggles (to remove the jupyterlab tests dir and stagingyarn.lockpost-install)test/config/templating/test_macros.pycovering defaults, version pins, extra packages, custom venv name, the 4-way strip-toggle matrix, and theRUNwrapperTest plan
just testpasses (1329 passed)jupyter_venv_nameplumbing is regressedimages-workbench(workbench-session) and confirm the rendered Dockerfile builds andjupyter --versionworks in the resulting image🤖 Generated with Claude Code