Remove wait-for-it.j2 macro#490
Merged
Merged
Conversation
ianpittwood
approved these changes
Apr 24, 2026
ianpittwood
force-pushed
the
worktree-pin-wait-for-it
branch
from
5991a1b to
18dca0a
Compare
Completes the SHA pinning started in PR #443. The core build workflows (ci.yml, bakery-build-*.yml) were already pinned; this covers the auxiliary workflows that were missed: docs.yml, hadolint.yml, and the slack-build-notify composite action. Mutable git tags are the exact vector exploited in the tj-actions supply chain attack (Unit 42, March 2025) — attackers overwrote tags to point to malicious commits.
The only consumer (images-workbench) now vendors the script directly. Removes the macro, its tests, and the CLAUDE.md reference. This eliminates a build-time download from a mutable GitHub branch with no integrity verification.
bschwedler
force-pushed
the
worktree-pin-wait-for-it
branch
from
18dca0a to
60f226c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait-for-it.j2macro, its tests, and the CLAUDE.md referenceThis macro downloaded from a mutable GitHub branch (
master) with no integrity verification at build time. Vendoring in the consumer repo eliminates the supply chain risk entirely.Test plan