Strip trailing whitespace from bakery.yaml writes#507
Merged
Conversation
Instructs Claude Code to let the hook run, read its output on failure, re-stage auto-fixed files, and commit again.
ruamel.yaml's round-trip serializer adds trailing spaces after YAML keys whose block scalar values continue on the next line (e.g. `documentationUrl: \n https://...`). This causes pre-commit trailing-whitespace failures every time bakery writes bakery.yaml — most visibly on release commits from the bot. Dump to a StringIO buffer first, strip trailing whitespace, then write the cleaned text to disk.
ianpittwood
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
documentationUrl: \n https://...)bakery create version/bakery patch versioncall triggersBakeryConfig.write(), which round-trips the entirebakery.yamlthrough ruamel — reintroducing the trailing whitespacetrailing-whitespacefailures on every release commit from the bot, requiring manual cleanup each timeThe fix dumps to a
StringIObuffer, strips trailing whitespace with a regex, then writes the cleaned text to disk.Test plan
images-connect/bakery.yaml— ruamel produces trailing space ondocumentationUrl:line; the fix removes it