Merged
Conversation
Test Results77 tests 76 ✅ 5s ⏱️ Results for commit a382c0e. ♻️ This comment has been updated with latest results. |
Contributor
Author
|
Example release draft: https://github.com/posit-dev/images-shared/releases/tag/untagged-e0038276a9546fd2b081 |
bschwedler
reviewed
Jan 16, 2025
Contributor
bschwedler
left a comment
bschwedler
left a comment
There was a problem hiding this comment.
I like this. Thanks!
One comment on removing the alpha from the version string.
bschwedler
reviewed
Jan 16, 2025
bschwedler
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19
^ This is arguable though, we should at least close it and replace it with another issue to upload to PyPI or CloudSmith.
vprefix, creates a draft release with attached build artifacts and auto-generated notes.pyproject.tomlwith poetry-dynamic-versioning to base build versions off repository tags. This will make the release behavior more similar to posit-dev/pti and will prevent us from needing to remember version bumps.