Conversation
Test Results137 tests 134 ✅ 50s ⏱️ Results for commit 65488db. ♻️ This comment has been updated with latest results. |
bschwedler
approved these changes
Feb 6, 2025
Contributor
bschwedler
left a comment
bschwedler
left a comment
There was a problem hiding this comment.
Please feel free to merge this.
We can always revisit how we are handling manifest updates when we formalise the cli contract.
- Add --force option to force re-render of a version from templates - Change --skip-mark-latest to --mark-latest defaulted to True - Fix missing value_map pass down to new version rendering - Fix (assumingly) unintentional usage of packaging.Version for build version output to manifest.toml, caused weird artifacts on non-standard versions (e.g. 2024.11.0-7 renders to 2024.11.0.post7) - Change BuildOS to use computed field properties instead of fields generated at __init__ to fix OS identification not working in version rendering
ianpittwood
force-pushed
the
fix-render
branch
from
a5e6cf6 to
65488db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94
Closes #95