Cover files-mode prompt-shaped raw stdout#60
Merged
Conversation
Cover the files-mode case where raw child stdout exactly matches a later R prompt/input echo. The existing source-aware echo collapse already preserves that raw output, so this records the behavior and marks the corresponding plan phase complete without changing runtime code. Validation: - cargo check - cargo build - cargo clippy --all-targets --all-features -- -D warnings - cargo test - cargo +nightly fmt
Make python_idle_exit_preserves_detached_tail_before_respawn release the detached writer only after the setup reply has returned. The old sleep-based ordering let the tail be emitted during the arming request on slower CI runners, so the follow-up assertion could miss output that had already been delivered. Validation: - cargo test python_idle_exit_preserves_detached_tail_before_respawn --test python_backend -- --nocapture - cargo test --test python_backend - cargo check - cargo build - cargo clippy --all-targets --all-features -- -D warnings - cargo test - cargo +nightly fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a files-mode regression showing that raw child stdout matching a later R input echo is kept visible, and only the matching echo produced by the R interpreter is elided.
No runtime code changed; the existing files-mode cleanup already uses framed
readline_resultfacts for this case.Public Facing Changes
Internal Changes
replsurface regression in files mode.Diff Composition
repl_surfaceregression and one Python lifecycle test synchronization fixValidation
cargo test python_idle_exit_preserves_detached_tail_before_respawn --test python_backend -- --nocapturecargo test --test python_backendcargo checkcargo buildcargo clippy --all-targets --all-features -- -D warningscargo testcargo +nightly fmtreview-loopagainstorigin/main