Skip to content

fix: allow validations to work with dates/datetimes#110

Merged
rich-iannone merged 3 commits intomainfrom
fix-validations-to-work-with-datetime
Mar 21, 2025
Merged

fix: allow validations to work with dates/datetimes#110
rich-iannone merged 3 commits intomainfrom
fix-validations-to-work-with-datetime

Conversation

@rich-iannone
Copy link
Member

This makes it somewhat easier to put together column-to-column validations with dates/datetimes. Now, this works with several of the validation methods. A series of followup PRs will make it work with comparisons against a static date or datetime, but this particular PR solves #106.

Fixes: #106

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.03%. Comparing base (8ead09b) to head (f1e1373).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pointblank/validate.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   99.09%   99.03%   -0.06%     
==========================================
  Files          17       17              
  Lines        3524     3534      +10     
==========================================
+ Hits         3492     3500       +8     
- Misses         32       34       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rich-iannone rich-iannone marked this pull request as ready for review March 21, 2025 20:54
@rich-iannone rich-iannone merged commit 2384fde into main Mar 21, 2025
5 checks passed
@rich-iannone rich-iannone deleted the fix-validations-to-work-with-datetime branch March 21, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for date type comparisons

2 participants