-
Notifications
You must be signed in to change notification settings - Fork 22
feat: column selectors for defining columns in validation workflow #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 99.73% 99.74% +0.01%
==========================================
Files 11 11
Lines 1902 1980 +78
==========================================
+ Hits 1897 1975 +78
Misses 5 5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on enhancing the
col_vals_*validation methods to acceptColumnobjects, which allows for more dynamic and flexible column comparisons.Updated the
col_vals_gt(),col_vals_lt(),col_vals_eq(),col_vals_ne(),col_vals_ge(),col_vals_le(),col_vals_between(), etc., etc., validation methods to acceptColumnobjects (throughcol()) incolumns=argument. This includes changes to parameter documentation and the addition of logic to handleColumnobjects appropriately. This is lazy, in that resolution of the columns by column selectors isn't performed until theinterrogate()method is called.Also added the
eval_errorattribute to the_ValidationInfoclass to track evaluation errors (e.g., column selectors not resolving to any columns. This provides useful information and also affects the final display of the validation report table.