Skip to content

Conversation

@rich-iannone
Copy link
Member

This PR focuses on enhancing the col_vals_* validation methods to accept Column objects, which allows for more dynamic and flexible column comparisons.

Updated the col_vals_gt(), col_vals_lt(), col_vals_eq(), col_vals_ne(), col_vals_ge(), col_vals_le(), col_vals_between(), etc., etc., validation methods to accept Column objects (through col()) in columns= argument. This includes changes to parameter documentation and the addition of logic to handle Column objects appropriately. This is lazy, in that resolution of the columns by column selectors isn't performed until the interrogate() method is called.

Also added the eval_error attribute to the _ValidationInfo class to track evaluation errors (e.g., column selectors not resolving to any columns. This provides useful information and also affects the final display of the validation report table.

@codecov
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (9fd0839) to head (621f83c).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   99.73%   99.74%   +0.01%     
==========================================
  Files          11       11              
  Lines        1902     1980      +78     
==========================================
+ Hits         1897     1975      +78     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rich-iannone rich-iannone marked this pull request as ready for review January 4, 2025 04:52
@rich-iannone rich-iannone merged commit 626d739 into main Jan 4, 2025
6 checks passed
@rich-iannone rich-iannone deleted the feat-col-exprs-in-validation branch January 4, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants