Merged
Conversation
Member
|
Thank you! Will review this soon. |
Contributor
Author
|
This should be ready to rock! Went from like 700 type errors to about 250! Everything so far has been pretty straight forward , hasn't required anything super crazy. |
rich-iannone
reviewed
Jan 3, 2026
rich-iannone
reviewed
Jan 3, 2026
rich-iannone
reviewed
Jan 3, 2026
rich-iannone
requested changes
Jan 3, 2026
Member
rich-iannone
left a comment
rich-iannone
left a comment
There was a problem hiding this comment.
This PR is overall really great, I just have a few concerns (look at comments to address).
Contributor
Author
Sounds good! Just responded to them or changed. Sorry this one feels like a monster PR haha |
rich-iannone
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #198 where I continue to type out the signatures in order to make the code more safe, easy to develop and "correct".