Skip to content

Add reference data as a default for aggregation comparison values#339

Merged
rich-iannone merged 4 commits intoposit-dev:mainfrom
tylerriccio33:ref-data
Jan 1, 2026
Merged

Add reference data as a default for aggregation comparison values#339
rich-iannone merged 4 commits intoposit-dev:mainfrom
tylerriccio33:ref-data

Conversation

@tylerriccio33
Copy link
Contributor

Summary

This PR allows the use of a reference to another dataset for the value comparison. Users pass an optional reference dataset to validate and for aggregation stats, if they leave the value empty, it will compare it to whatever is in the reference data. The use case would be tracking changes in composition across some interval. This would be personally incredibly useful.

Checklist

  • [ x] I understand and agree to the Code of Conduct.
  • [ x] I have followed the Style Guide for Python Code as best as possible for the submitted code.
  • [ x] I have added pytest unit tests for any new functionality.

@tylerriccio33 tylerriccio33 marked this pull request as ready for review January 1, 2026 16:10
@rich-iannone
Copy link
Member

This looks great! I'll review right now.

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit 1d8699d into posit-dev:main Jan 1, 2026
9 checks passed
@tylerriccio33
Copy link
Contributor Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants