Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 16 16
Lines 3206 3206
=======================================
Hits 3175 3175
Misses 31 31 ☔ View full report in Codecov by Sentry. |
Member
|
This sounds like a great plan. Thanks for all this! |
rich-iannone
reviewed
Mar 2, 2025
rich-iannone
requested changes
Mar 2, 2025
Member
rich-iannone
left a comment
There was a problem hiding this comment.
Looks good! The only small thing is removing "black" from the dev list in [dependency-groups].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the pr to add the linter to ci and the project generally, raised in #74 . Since this is touching the ci cycle I want to do this in stages, so if you could keep the branch open it would be appreciated. So, in this initial push I added ruff to the pyproject toml and the make command.
If this is all good, after you merge it I'll actually apply the linter which should be a giant pr; why I wanted to split this up.
If the actual linting is all good, I'll add this as a pre-commit (I'll update the contribution guide) and add it to the github actions.
Let me know if this is in line with what you're thinking.