Skip to content

Add ruff#76

Merged
rich-iannone merged 5 commits intoposit-dev:mainfrom
tylerriccio33:add-ruff
Mar 3, 2025
Merged

Add ruff#76
rich-iannone merged 5 commits intoposit-dev:mainfrom
tylerriccio33:add-ruff

Conversation

@tylerriccio33
Copy link
Contributor

@tylerriccio33 tylerriccio33 commented Mar 2, 2025

This is the pr to add the linter to ci and the project generally, raised in #74 . Since this is touching the ci cycle I want to do this in stages, so if you could keep the branch open it would be appreciated. So, in this initial push I added ruff to the pyproject toml and the make command.

If this is all good, after you merge it I'll actually apply the linter which should be a giant pr; why I wanted to split this up.

If the actual linting is all good, I'll add this as a pre-commit (I'll update the contribution guide) and add it to the github actions.

Let me know if this is in line with what you're thinking.

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.03%. Comparing base (0bc5566) to head (068ba22).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files          16       16           
  Lines        3206     3206           
=======================================
  Hits         3175     3175           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rich-iannone
Copy link
Member

This sounds like a great plan. Thanks for all this!

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only small thing is removing "black" from the dev list in [dependency-groups].

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit fb99b5d into posit-dev:main Mar 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants