Fix Echo test provider to respect default model preference setting#11295
Fix Echo test provider to respect default model preference setting#11295cameronmpalmer wants to merge 2 commits intoposit-dev:mainfrom
Conversation
The Echo language model provider was hardcoding isDefault: true on the first model, ignoring the user's models.preference.byProvider setting. Now it uses markDefaultModel() like other providers, allowing developers to test default model selection behavior with the Echo provider.
Signed-off-by: sharon <sharon-wang@users.noreply.github.com>
sharon-wang
left a comment
There was a problem hiding this comment.
Thanks for fixing this up!
This particular file is being reorganized into multiple files in #11089. It's a big refactor PR that should be going in within the next day or so. Would you be up for waiting for that PR to be merged, and porting this change over to the new file (should be in extensions/positron-assistant/src/providers/test/echoProvider.ts)?
Can do! |
|
@sharon-wang Ported to non-fork PR with refactored changes in #11362 |
Summary
models.preference.byProvidersettingisDefault: trueon the first model instead of usingmarkDefaultModel()like other providersQA Notes
To test: