Skip to content

Fix Echo test provider to respect default model preference setting#11295

Closed
cameronmpalmer wants to merge 2 commits intoposit-dev:mainfrom
cameronmpalmer:fix-echo-provider-default-model-preference
Closed

Fix Echo test provider to respect default model preference setting#11295
cameronmpalmer wants to merge 2 commits intoposit-dev:mainfrom
cameronmpalmer:fix-echo-provider-default-model-preference

Conversation

@cameronmpalmer
Copy link
Copy Markdown
Contributor

Summary

  • Fix Echo language model provider ignoring the user's models.preference.byProvider setting
  • The provider was hardcoding isDefault: true on the first model instead of using markDefaultModel() like other providers

QA Notes

To test:

  1. Add the Echo provider via "Positron Assistant: Configure Models"
  2. Set a preference in settings:
    "positron.assistant.models.preference.byProvider": {
        "echo": "v2"
    }
  3. Reload the window
  4. Open the Assistant panel and check the model picker - "Echo Language Model v2" should show "(default)" indicator

The Echo language model provider was hardcoding isDefault: true on the
first model, ignoring the user's models.preference.byProvider setting.

Now it uses markDefaultModel() like other providers, allowing developers
to test default model selection behavior with the Echo provider.
Signed-off-by: sharon <sharon-wang@users.noreply.github.com>
Copy link
Copy Markdown
Member

@sharon-wang sharon-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up!

This particular file is being reorganized into multiple files in #11089. It's a big refactor PR that should be going in within the next day or so. Would you be up for waiting for that PR to be merged, and porting this change over to the new file (should be in extensions/positron-assistant/src/providers/test/echoProvider.ts)?

@cameronmpalmer
Copy link
Copy Markdown
Contributor Author

Thanks for fixing this up!

This particular file is being reorganized into multiple files in #11089. It's a big refactor PR that should be going in within the next day or so. Would you be up for waiting for that PR to be merged, and porting this change over to the new file (should be in extensions/positron-assistant/src/providers/test/echoProvider.ts)?

Can do!

@cameronmpalmer
Copy link
Copy Markdown
Contributor Author

@sharon-wang Ported to non-fork PR with refactored changes in #11362

@github-actions github-actions Bot locked and limited conversation to collaborators Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants