Skip to content

Add theme colors for base checkboxes #13813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhruvisompura merged 1 commit into from
May 28, 2026
Merged

Add theme colors for base checkboxes #13813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build/lib/stylelint/vscode-known-variables.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,9 @@
"--vscode-positronActionBar-textInputSelectionBackground",
"--vscode-positronActionBar-textInputSelectionForeground",
"--vscode-positronActionBar-toggleButtonHighlightedBorder",
"--vscode-positronCheckbox-background",
"--vscode-positronCheckbox-border",
"--vscode-positronCheckbox-foreground",
"--vscode-positronConsole-ansiBlack",
"--vscode-positronConsole-ansiBlue",
"--vscode-positronConsole-ansiBrightBlack",
Expand Down Expand Up @@ -693,9 +696,6 @@
"--vscode-positronModalDialog-buttonDisabledForeground",
"--vscode-positronModalDialog-buttonForeground",
"--vscode-positronModalDialog-buttonHoverBackground",
"--vscode-positronModalDialog-checkboxBackground",
"--vscode-positronModalDialog-checkboxBorder",
"--vscode-positronModalDialog-checkboxForeground",
"--vscode-positronModalDialog-contrastBackground",
"--vscode-positronModalDialog-defaultButtonBackground",
"--vscode-positronModalDialog-defaultButtonForeground",
Expand Down
8 changes: 4 additions & 4 deletions src/vs/base/browser/ui/positronComponents/checkbox/checkbox.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*---------------------------------------------------------------------------------------------
* Copyright (C) 2022 Posit Software, PBC. All rights reserved.
* Copyright (C) 2022-2026 Posit Software, PBC. All rights reserved.
* Licensed under the Elastic License 2.0. See LICENSE.txt for license information.
*--------------------------------------------------------------------------------------------*/

Expand All @@ -20,9 +20,9 @@
border-radius: 3px;
align-items: center;
justify-content: center;
color: var(--vscode-positronModalDialog-checkboxForeground);
background: var(--vscode-positronModalDialog-checkboxBackground);
border: 1px solid var(--vscode-positronModalDialog-checkboxBorder);
color: var(--vscode-positronCheckbox-foreground);
background: var(--vscode-positronCheckbox-background);
border: 1px solid var(--vscode-positronCheckbox-border);
}

.positron-dynamic-modal-dialog-box .checkbox-input[type="checkbox"]:focus {
Expand Down
6 changes: 3 additions & 3 deletions src/vs/workbench/browser/positronComponents/positronModalDialog/components/checkbox.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
border-radius: 3px;
justify-content: center;
color: var(--vscode-positronModalDialog-buttonForeground);
background: var(--vscode-positronModalDialog-checkboxBackground);
border: 1px solid var(--vscode-positronModalDialog-checkboxBorder);
background: var(--vscode-positronCheckbox-background);
border: 1px solid var(--vscode-positronCheckbox-border);
}

.positron-modal-dialog-box .checkbox-button:focus {
Expand All @@ -34,5 +34,5 @@
.positron-modal-dialog-box .checkbox-button .codicon[class*="codicon-"] {
font-size: 12px;
font-weight: bold;
color: var(--vscode-positronModalDialog-checkboxForeground);
color: var(--vscode-positronCheckbox-foreground);
}
52 changes: 26 additions & 26 deletions src/vs/workbench/common/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,32 +1288,6 @@ export const POSITRON_MODAL_DIALOG_TEXT_INPUT_SELECTION_BACKGROUND = registerCol
hcLight: '#007acc'
}, localize('positronModalDialog.textInputSelectionBackground', "Positron modal dialog text input selection background color."));

// < --- Positron Modal Dialog Checkbox --- >

// Positron modal dialog checkbox background color.
export const POSITRON_MODAL_DIALOG_CHECKBOX_BACKGROUND = registerColor('positronModalDialog.checkboxBackground', {
dark: '#292f32',
light: '#ffffff',
hcDark: checkboxBackground,
hcLight: checkboxBackground
}, localize('positronModalDialog.checkboxBackground', "Positron modal dialog checkbox background color."));

// Positron modal dialog checkbox foreground color.
export const POSITRON_MODAL_DIALOG_CHECKBOX_FOREGROUND = registerColor('positronModalDialog.checkboxForeground', {
dark: foreground,
light: '#000000',
hcDark: checkboxForeground,
hcLight: checkboxForeground
}, localize('positronModalDialog.checkboxForeground', "Positron modal dialog checkbox foreground."));

// Positron modal dialog checkbox border color.
export const POSITRON_MODAL_DIALOG_CHECKBOX_BORDER = registerColor('positronModalDialog.checkboxBorder', {
dark: '#292f32',
light: '#a6a6a6',
hcDark: checkboxBorder,
hcLight: checkboxBorder
}, localize('positronModalDialog.checkboxBorder', "Positron modal dialog checkbox border."));

// < --- Positron Modal Dialog Radio Button --- >

// Positron modal dialog radio button background color.
Expand Down Expand Up @@ -1488,6 +1462,32 @@ export const POSITRON_DROP_DOWN_SEPARATOR_BACKGROUND = registerColor('positronDr
hcLight: menuBorder
}, localize('positronDropDownListBox.separatorBackground', "Positron drop down list box separator background color."));

// < --- Positron Base Checkbox --- >

// Positron base checkbox background color.
export const POSITRON_CHECKBOX_BACKGROUND = registerColor('positronCheckbox.background', {
dark: '#292f32',
light: '#ffffff',
hcDark: checkboxBackground,
hcLight: checkboxBackground
}, localize('positronCheckbox.background', "Positron base checkbox background color."));

// Positron base checkbox foreground color.
export const POSITRON_CHECKBOX_FOREGROUND = registerColor('positronCheckbox.foreground', {
dark: foreground,
light: '#000000',
hcDark: checkboxForeground,
hcLight: checkboxForeground
}, localize('positronCheckbox.foreground', "Positron base checkbox foreground color."));

// Positron base checkbox border color.
export const POSITRON_CHECKBOX_BORDER = registerColor('positronCheckbox.border', {
dark: '#292f32',
light: '#a6a6a6',
hcDark: checkboxBorder,
hcLight: checkboxBorder
}, localize('positronCheckbox.border', "Positron base checkbox border color."));

// < --- Positron Console --- >

// Positron console background color.
Expand Down
Loading