refactor: move projectDir resolution into QuartoProjectHelper#4070
refactor: move projectDir resolution into QuartoProjectHelper#4070posit-connect-projects[bot] wants to merge 2 commits into
Conversation
Add optional rootDir parameter to QuartoProjectHelper constructor so it can resolve relative projectDir values internally. This removes the need for callers (homeView.ts) to resolve paths before constructing the helper. Addresses review feedback from #4048. Co-authored-by: zackverham <zackverham@users.noreply.github.com>
…r-resolve-projectdir # Conflicts: # extensions/vscode/src/utils/quartoProjectHelper.smoke.test.ts
18ba333 to
9d283e9
Compare
|
@claude is there any manual testing we can do to smoke test this change? |
|
Claude finished @zackverham's task in 53s —— View job Manual Testing for
|
Summary
Follows up on review feedback from #4048 (comment) —
QuartoProjectHelpernow handles resolving relativeprojectDirvalues internally via a new optionalrootDirconstructor parameter, instead of requiring callers to resolve paths before constructing the helper.rootDirparameter toQuartoProjectHelperconstructor that resolvesprojectDiragainstrootDirusingpath.resolve()renderQuartoContent()to accept and forwardrootDirhomeView.tsto pass the workspace root asrootDirinstead of resolving the path manuallyNote: This PR will have a small merge conflict with #4048 in
homeView.ts(both PRs touch therenderContentmethod). Whichever merges second will need a trivial conflict resolution.Test plan
rootDirresolution inquartoProjectHelper.test.ts(relative, nested relative, absolute, omitted)rootDirwith real filesystem inquartoProjectHelper.smoke.test.ts(path resolution,_quarto.ymldetection, command construction)🤖 Generated with Claude Code