feat(pkg-r): Use cli for errors and warnings #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace rlang::abort(), rlang::warn(), and message() with their cli equivalents (cli::cli_abort(), cli::cli_warn(), cli::cli_inform()) throughout the R package. The cli package provides better-formatted, user-friendly messages with consistent styling. Changes: - Add cli to DESCRIPTION Imports - Replace error/warning/message functions in QueryChat.R, data_source.R, querychat_module.R, and utils-ellmer.R - Improve one error message to use cli's structured format with interpolation Closes #114 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
gadenbuie
reviewed
Dec 3, 2025
Comment on lines
+24
to
26
| cli::cli_abort( | ||
| "`table_name` argument must be a string containing alphanumeric characters and underscores, starting with a letter." | ||
| ) |
Contributor
There was a problem hiding this comment.
Um... part of wanting to use cli_abort() over rlang::abort() is to take advantage of cli's inline markup formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace rlang::abort(), rlang::warn(), and message() with their cli equivalents (cli::cli_abort(), cli::cli_warn(), cli::cli_inform()) throughout the R package. The cli package provides better-formatted, user-friendly messages with consistent styling.
Changes:
Closes #114
🤖 Generated with Claude Code