chore: sql() reactive returns NULL or None if not set
#149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
commented
Dec 8, 2025
| return data_source.get_data() | ||
| else: | ||
| return data_source.execute_query(sql.get()) | ||
| return data_source.execute_query(query) |
Contributor
Author
There was a problem hiding this comment.
If we update .execute_query() to accept a None value, similar to "", we could avoid needing to store the result of sql.get() in an intermediate variable (to satisfy the type checker).
Contributor
There was a problem hiding this comment.
Yea, seems like that'd be a good idea?
Contributor
Author
There was a problem hiding this comment.
Nah, that means we'd have to change the return value of execute_query() which currently is annotated as pd.Dataframe, which then has implications in the base and extender classes. That doesn't seem worth it to me.
Contributor
There was a problem hiding this comment.
Ah ok, the current approach seems fine 👍
cpsievert
reviewed
Dec 8, 2025
cpsievert
added a commit
that referenced
this pull request
Dec 9, 2025
cpsievert
added a commit
that referenced
this pull request
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146
This PR updates the
sql()reactive to be a string orNULL/None, makingsql()consistent withtitle().The other way to have made these consistent would have been to set them to
""when unset. That would make checking for emptiness easier, but didn't feel quite right, so I went with the current approach. I largely expect the overall impact to be minimal.