-
Notifications
You must be signed in to change notification settings - Fork 22
feat(pkg-r): Rich tools #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements rich tools functionality for the querychat package using the latest version of shinychat. It adds an "Apply Filter" button that allows users to reapply previous filters from tool results, enhancing the user experience for working with data queries.
Key changes include:
- Refactored tool implementations into separate files for better code organization
- Added rich tool annotations with icons and better UI presentation
- Implemented JavaScript functionality for the "Apply Filter" button interaction
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg-r/inst/htmldep/querychat.js | Adds JavaScript event handling for the "Apply Filter" button functionality |
| pkg-r/R/querychat_tools.R | New file containing refactored tool implementations with rich annotations |
| pkg-r/R/querychat.R | Updated to use new tool structure and proper HTML dependencies |
| pkg-r/NEWS.md | Documents the new rich tools feature |
| pkg-r/DESCRIPTION | Updates shinychat dependency and adds remote repository |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Fixes #62
Uses rich tools with the latest version of shinychat. Includes an "Apply Filter" button that is shown in the update dashboard tool results so that you can go back and apply previous filters.
Also refactors the tools into separate files for better organization