Skip to content

Address a few nits and a bug #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

Address a few nits and a bug #142

merged 1 commit into from
Jun 23, 2020

Conversation

@meatballhat
Copy link
Contributor

@meatballhat meatballhat commented Jun 23, 2020

Description

found during rsconnect-juptyer testing

Connected to rstudio/connect#17780

Testing Notes / Validation Steps

  • deployment via rsconnect-jupyter does not fail when the conda path is taken

@meatballhat
Address a few nits and a bug
1ec36aa 
found during rsconnect-juptyer testing
@meatballhat meatballhat requested review from Lytol and mmarchetti June 23, 2020 12:25
@meatballhat
Copy link
Contributor Author

meatballhat commented Jun 23, 2020

fwiw I'm working to add mypy in a separate PR so that we can catch bugs like this in the future:

rsconnect/environment.py:71: error: Incompatible return value type (got "Dict[str, str]", expected "Environment")
Found 1 error in 1 file (checked 9 source files)

@meatballhat meatballhat merged commit e49fc2c into master Jun 23, 2020
@meatballhat meatballhat deleted the mbh-jupyter-testing-bugs branch June 23, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lytol Lytol Awaiting requested review from Lytol

1 more reviewer

@mmarchetti mmarchetti mmarchetti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meatballhat @mmarchetti