md5 fallback for FIPS mode #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We compute file and buffer checksums to support a file upload integrity check, using
hashlib.md5which is in the Python standard library. It's possible to have a python installation where this function is not available or requires special handling; this is related to building openssl in FIPS mode. This PR enables a fallback mode if hashlib.md5 is not available, by trying md5 with theusedforsecurityoption set to False (this is new in Python 3.9).Connected to #174
Testing Notes / Validation Steps
Test deploying content, on a normal python installation and one which is configured for FIPS (where
hashlib.md5requires theusedforsecurityparameter to be False in order to function).