Skip to content

refactor #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 127 commits into from
Jul 1, 2022
Merged

refactor #244

merged 127 commits into from
Jul 1, 2022

Conversation

@bcwu
Copy link
Contributor

@bcwu bcwu commented May 4, 2022 •
edited
Loading

Description

Refactor various parts of the code to make the programmatic side easier to understand and more extensible.

Notes for QA

deploy

  • api
    • --new
    • re-deploy
  • bokeh
  • dash
  • fastapi
  • html
  • manifest
  • notebook
  • other-content
  • quarto
  • streamlit

errors

  • redeploy with different mode should raise error

bcwu added 20 commits May 4, 2022 18:20
@bcwu
initial commit of refactor
9e81d4a
@bcwu
change some functions into RSConnectServer methods
544ab0a
@bcwu
change make_bundle to be a dependency injection
ae8b90c
@bcwu
change initialization
50b02c6
@bcwu
move functions from server to executor
bf01943
@bcwu
add get method that allows overwrites
cdb1c58
@bcwu
remove state setter since it doesn't allow setting kwargs
9bf2220
@bcwu
update and use get method
5affba4
@bcwu
use built-in deprecation warnings
45b6b44
@bcwu
update formatting
b7ccea1
@bcwu
refactor make_deployment_name
c942f78
@bcwu
move RSConnectException into its own file
d42b9e9
@bcwu
move _to_server_check_list & _default_title
718ec45
@bcwu
remove cli_feedback from make_bundle
fdc6b0f
@bcwu
setup Connect automatically from kwargs
e51ef47
@bcwu
refactor html_bundle
2e20028
@bcwu
correct dictionary being passed to make_bundle
664d310
@bcwu
various small updates
371f71e
@bcwu
deploy_bundle; TODO: save deploy info in app_store
aa4198e
@bcwu
add pipe operator
7ffb0e5
mmarchetti
mmarchetti suggested changes May 13, 2022
View reviewed changes
bcwu added 22 commits June 15, 2022 16:00
@bcwu
add cli_exception_handler
d4c792c
@bcwu
update cli_exception_handler
52d2ae3
@bcwu
add exception for no name and no server url
eb1b829
@bcwu
clarify cacert to ca_data process
bc9465a
@bcwu
add fromConnectServer classmethod
d7527eb
@bcwu
fix static mode not being considered in deploy notebook
5f1ba9f
@bcwu
fix notebook static deploy
8fb3e2c
@bcwu
validate_extra_files should happen outside create_python_environment
96d55b6
@bcwu
remove unused import
5cd14b9
@bcwu
fix app mode check for Python apps
fda2db1
@bcwu
fix a circular import reference with RSConnectException
caf7644
@bcwu
AppStore needs to be initialized from module_file
397b700
@bcwu
init app_store with module_file if it doesn't exist
c9c9e72
@bcwu
re-use resolved app_id for redeployments
f61bf8c
@bcwu
save validated entrypoint in generate_deploy_python
31794e0
@bcwu
Merge branch 'master' into bcwu-refactor
a95d21e
@bcwu
add file_or_directory to path resolution
42742a7
@bcwu
add guard to extra_files being None
9c05711
@bcwu
update api cls method
b5f6f5c
@bcwu
add filter_out_server_info
6193b3c
@bcwu
add deploy_html as an action & unify its implementation across main a…
b6e75d5 
…nd actions
@bcwu
update type annotations
49de7fd
mmarchetti
mmarchetti reviewed Jun 28, 2022
View reviewed changes
mmarchetti
mmarchetti approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@mmarchetti mmarchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some improvements that could be made, but I don't think this PR is the place to make them at this point.

@bcwu bcwu merged commit 01d59e9 into master Jul 1, 2022
@bcwu bcwu deleted the bcwu-refactor branch July 1, 2022 15:23
@tdstein tdstein mentioned this pull request Jan 30, 2023
Merged
7 tasks
@aronatkins aronatkins mentioned this pull request Jan 16, 2024
Closed
@jonkeane jonkeane mentioned this pull request Mar 7, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mmarchetti mmarchetti mmarchetti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bcwu @kgartland-rstudio @mmarchetti