Skip to content

Switch image parameters to be optional at public api layer #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 31, 2022
Merged

Switch image parameters to be optional at public api layer #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5e71eb3
revert parameters to optional for rsc-jupyter
bcwu May 26, 2022
5145510
revert some parameters in actions
bcwu May 26, 2022
e8e7046
revert more actions
bcwu May 26, 2022
98bac97
update tests
bcwu May 26, 2022
81dcc58
update test_actions
bcwu May 26, 2022
4388bfa
make hide_all_input and hide_tagged_input required
bcwu May 26, 2022
93aefd4
add missing extra_files back to test
bcwu May 26, 2022
034027d
move image in pubic api to optional
sagerb May 26, 2022
df99618
Merge remote-tracking branch 'origin/bcwu-rscj-backward-compatibility…
sagerb May 26, 2022
814b23a
image param optional in public layer
sagerb May 26, 2022
7f4330d
Changelog entry
sagerb May 26, 2022
1dc3282
remove extra code around check_output
bcwu May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- You can now deploy static content such as html and its associated assets with
`rsconnect deploy html`.

- An optional `image` parameter has been added to the applicable functions to support
target content image. This parameter defaults to `None` if not provided.

## [1.7.1] - 2022-02-15

### Added
Expand Down
Loading