support for shinyapps.io #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinyapps.io support branch
…nto bcwu-merge-shinyapps
added 6 commits
July 5, 2022 11:29
Initialize S3 server like other servers
bcwu
reviewed
Jul 5, 2022
bcwu
reviewed
Jul 5, 2022
bcwu
reviewed
Jul 5, 2022
added 10 commits
July 5, 2022 16:09
ssinnott
approved these changes
Jul 7, 2022
Collaborator
ssinnott
left a comment
ssinnott
left a comment
There was a problem hiding this comment.
There's some broken tests after the merge... but the script works for deploying to shinyapps.io locally on my end. So I think it's good to go from my perspective.
bcwu
reviewed
Jul 8, 2022
bcwu
reviewed
Jul 8, 2022
Comment on lines
+283
to
+300
| @click.option( | ||
| "--account", | ||
| "-a", | ||
| envvar="SHINYAPPS_ACCOUNT", | ||
| help="The shinyapps.io account name.", | ||
| ) | ||
| @click.option( | ||
| "--token", | ||
| "-T", | ||
| envvar="SHINYAPPS_TOKEN", | ||
| help="The shinyapps.io token.", | ||
| ) | ||
| @click.option( | ||
| "--secret", | ||
| "-S", | ||
| envvar="SHINYAPPS_SECRET", | ||
| help="The shinyapps.io token secret.", | ||
| ) |
Contributor
There was a problem hiding this comment.
these new options could be all added under @server_args https://github.com/rstudio/rsconnect-python/blob/72c58f47675c7db84632a0688c49400ca2ea73dc/rsconnect/main.py#L100-L133
Member
Author
There was a problem hiding this comment.
The only method that will work with shinyapps.io right now is deploy_manifest, so I think it would be misleading for rsconnect-python to explicitly accept those options for the other methods.
bcwu
reviewed
Jul 8, 2022
bcwu
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for adding shinyapps.io credentials and deploying to shinyapps.io.