Skip to content

Conversation

@bcwu
Copy link
Contributor

@bcwu bcwu commented Jan 25, 2023

fixes #341

Copy link
Collaborator

@tdstein tdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Validated that set#union does not modify the original set.

@kgartland-rstudio
Copy link
Contributor

Confirmed that extra files are ignored and not present in Connect after deployment when deployed with rsconnect-python 1.14.

Validated multiple files do deploy properly on this branch.

We do have a test in the rsconnect-python tests in Connect but we do not check to see if the files actually made it to Connect. I'll add an additional check there so we don't hit this again.

@bcwu bcwu merged commit 40c12fc into master Jan 31, 2023
@bcwu bcwu deleted the bcwu-fix-htmlextrafiles branch January 31, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploying additional files

4 participants