fix voila extra files #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcwu
force-pushed
the
bcwu-extrafiles-voila
branch
from
6c8501d to
1b31caa
Compare
mmarchetti
approved these changes
Mar 24, 2023
Contributor
mmarchetti
left a comment
mmarchetti
left a comment
There was a problem hiding this comment.
The code looks good and I appreciate the added unit test. Can you also add QA notes to the PR?
Contributor
|
Verified fixed:
Are there any other areas to test? |
Contributor
Author
|
Contributor
|
I've tested those scenarios as well. If there are no other content types expected to be impacted, feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
fixes #381
This bug likely appeared after refactoring deploy html.
Type of Change
Checklist