Add support for specifying visibility for Posit Cloud and shinyapps.io deploys #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mbaynton
approved these changes
Apr 13, 2023
omar-rs
approved these changes
Apr 13, 2023
Member
Author
|
@scubastevew Take a look at this change when you get a chance. |
|
Tested:
|
mmarchetti
approved these changes
Jun 20, 2023
| if visibility != application["deployment"]["properties"]["application.visibility"]: | ||
| self._rstudio_client.update_application_property( | ||
| application["id"], "application.visibility", visibility | ||
| ) |
Contributor
There was a problem hiding this comment.
Does this need to call handle_bad_response?
Member
Author
There was a problem hiding this comment.
Yes :) thanks for catching that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #356.
Intent
This change adds support for specifying a
--visibilityflag to shinyapps.io deploys. Visibility can bepublicorprivate.Type of Change
Approach
If the deploy creates a new application and
--visibilityis provided, the visibility is set. If we're updating an existing application and--visibilityis provided, we get the existing visibility, compare it to the provided visibility, and update it if the values differ.Automated Tests
Updated the automated tests to pass
--visibilityand added/updated HTTP mocks to match the change in API calls.Directions for Reviewers
Important cases to test are:
--visibility--visibilityChecklist