bug: allow requirements.txt to not exist #751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Previously
rsconnectdidn't check that therequirements.txtdidn't exist, it did just emit a warningNow instead it errors if the requirements file doesn't exist
The change in behavior accidentally slipped in as part of #748 as
click.Pathunexpectedly validates the default value too even if the option wasn't provided.Type of Change
Approach
Just disable
exists=Truefrom command line validation, this will restore the previous behavior of issuing the warning.Automated Tests
Tests in Connect triggered this issue