feat(r-shinychat): custom icons #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
feat/r-custom-icons
branch
from
4dfd4cb to
3c65697
Compare
cpsievert
force-pushed
the
feat/r-custom-icons
branch
from
3c65697 to
32a6dad
Compare
gadenbuie
reviewed
Aug 22, 2025
htmltools in R doesn't turn `icon_assistant` into kebab case
gadenbuie
approved these changes
Aug 22, 2025
Collaborator
gadenbuie
left a comment
gadenbuie
left a comment
There was a problem hiding this comment.
I brought this up-to-date with main and fixed a couple of small issues. It works great now!
I added a test app you can run with
setwd("pkg-r")
load_all()
shiny::runApp(test_path("apps", "icon"))I think we should have more formal testing around this, but I'm happy to merge it as-is and come back to testing after conf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58
TODO