fix: bump controller manager memory limit from 128Mi to 192Mi#127
fix: bump controller manager memory limit from 128Mi to 192Mi#127stevenolen merged 2 commits intomainfrom
Conversation
The controller manager pod was OOMKilling in production. Increase the default memory limit to 192Mi to provide headroom.
|
Claude finished @stevenolen's task —— View job Reviewing PR
Review submitted. Key finding: |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review: bump controller manager memory limit
Helm Chart Checklist:
- Values have sensible defaults — 192Mi is a reasonable bump from 128Mi
- README updated to reflect the new default
- All four files are consistent at
192Mi
One observation:
In config/default/manager_auth_proxy_patch.yaml:47, the 128→192Mi change applies to the kube-rbac-proxy sidecar container, not the manager container (which starts at line 51). The other three files (config/manager/manager.yaml, dist/chart/values.yaml, dist/chart/README.md) all change the manager container's limit.
Was the proxy sidecar also OOMing, or was this an unintentional inclusion? If the OOM was only on the manager process, this change to the proxy is unnecessary (though harmless). Worth confirming intent.
Self-review note: The PR checklist shows just test hasn't been checked off — please confirm tests pass before merge.
The 192Mi bump was mistakenly applied to the kube-rbac-proxy sidecar instead of the manager container. Revert the proxy limit back to 128Mi.
## [1.23.3](v1.23.2...v1.23.3) (2026-04-28) ### Bug Fixes * bump controller manager memory limit from 128Mi to 192Mi ([#127](#127)) ([cd40dc0](cd40dc0))
2 participants
Description
The controller manager pod was OOMKilling in production. This increases the default memory limit from 128Mi to 192Mi to provide additional headroom.
Category of change
Checklist
just testand all tests pass