Conversation
Some fields in the JSON are numbers -- and numbers in JSON are all one type. Aeson sees them as this "Scientific" number -- a float or double? So if WordPress has a post with an "id" 34234, then Offset fills it as "34234.0". Which is bad when we're creating links to "author/${wpId}".
The problem seems to be that Fields have some different types, like objects or lists, but there's no "type" that says anything about the content of a field.
Ideally, it would be getting a JSON Number, then trying to convert that into an Integer. But what the "build splices"
This reverts commit a29cdf7.
Member
Author
|
@mattraibert Could also do: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.