Conversation
Still missing: Good uids for entries, probably others... Also: This currently expects that there is an "authors" field with multiple authors, which isn't true unless you're using guest-authors. Need some way to allow both ooptions.
emhoracek
commented
May 11, 2017
spec/Common.hs
Outdated
| , "departments" .= [ object [ "name" .= ("some department" :: T.Text)]] | ||
| , "department" .= ("15" :: T.Text) | ||
| , "authors" .= [ object ["name" .= ("Emma Goldman" :: T.Text)]] | ||
| , "format" .= ("standard" :: T.Text) ] |
Member
Author
There was a problem hiding this comment.
Added fields expected by the feed: "modified", "guid", "authors" -- latter two are temporary I think. The entry id should be generated to point to the Offset server, not the WordPress server (although it doesn't matter if it's a real, clickable URL). The "authors" field is there because Jacobin needs multiple authors, but we need to support at least both guest-authors and the default user authors. (The "format" field is a mistake.)
emhoracek
commented
May 11, 2017
| Right resp -> | ||
| case decode resp of | ||
| Just posts -> return posts | ||
| Nothing -> error $ "Couldn't decode: " <> T.unpack resp |
Member
Author
There was a problem hiding this comment.
need to figure out if it's okay to throw errors here
Member
Author
There was a problem hiding this comment.
actually there's dubious error-throwing all over the place
dhartunian
approved these changes
May 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still missing: Good uids for entries, probably others...
Also: This currently expects that there is an "authors" field with multiple authors, which isn't true unless you're using guest-authors. Need some way to allow both options.