Boolean 'false' fields are not displayed#52
Merged
Conversation
dhartunian
suggested changes
Jul 20, 2017
| boolFieldTrue = object [ "person" .= object [ "name" .= ("Ada Lovelace" :: Text )]] | ||
|
|
||
| boolFieldFalse :: Value | ||
| boolFieldFalse = object [ "person" .= False ] |
Contributor
There was a problem hiding this comment.
i think in our case the value is the string "false" not the boolean false
Member
Author
There was a problem hiding this comment.
I don't think so... I did check but let me verify.
| Right i -> rawTextFill $ tshow (i :: Integer) | ||
| jsonToFill (Bool b) = rawTextFill $ tshow b | ||
| jsonToFill (Bool True) = rawTextFill $ tshow True | ||
| jsonToFill (Bool False) = rawTextFill "<!-- JSON field found, but value is false. -->" |
Contributor
There was a problem hiding this comment.
I dont think we want all boolean false values to render this, no?
Member
Author
There was a problem hiding this comment.
I can't imagine ever wanting "false" (or even "true")
Member
Author
There was a problem hiding this comment.
Do you have another idea?
dhartunian
approved these changes
Jul 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, update to use latest Larceny.