Add a Field for additional queries with multiple IDs#64
Merged
Conversation
EndpointKey separates params instead of concatting onto endpoint Make tests pass
emhoracek
force-pushed
the
add-list-of-query
branch
from
f00052a to
f343303
Compare
dhartunian
approved these changes
Jun 12, 2019
spec/Main.hs
Outdated
| let tpl = toTpl "<wp><wpPostByPermalink><wpDepartment><wpName /></wpDepartment></wpPostByPermalink></wp>" | ||
| rendered <- evalStateT (runTemplate tpl [] s mempty) ctxt' | ||
| rendered `shouldBe` "Sports" | ||
| it "should render stuff 2" $ do |
Contributor
There was a problem hiding this comment.
any chance we can improve naming here? :)
Member
Author
There was a problem hiding this comment.
lmao I forgot about that, the previous one should probably be changed from "should render stuff" as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.