Removes Scikit-Learn dependency. #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This needs pull request #8 to fix the build. |
| 'maintainer_email': 'fritz.obermeyer@gmail.com', | ||
| 'license': 'Revised BSD', | ||
| 'install_requires': ['numpy', 'scipy', 'scikit-learn'], | ||
| 'install_requires': ['numpy', 'scipy'], |
Member
There was a problem hiding this comment.
Nice! It's great to remove this dependency.
This commit uses the SciPy KDTree implementation to compute nearest neighbors instead of the Scikit-Learn implementation. This eliminates the need for the `sklearn` dependency altogether.
jfinkels
force-pushed
the
remove-sklearn
branch
from
fe49d2d to
5403131
Compare
Contributor
Author
|
The build seems to pass. I'm not familiar enough with the code to know if there's any other subtle issues with nearest neighbors, so I would keep an eye on dependent code to see if anything strange pops up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses the SciPy KDTree implementation to compute nearest
neighbors instead of the Scikit-Learn implementation. This eliminates
the need for the
sklearndependency altogether.This fixes issue #6.