Cache miss #615
Open
Cache miss #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montanalow
requested changes
May 4, 2023
| return result | ||
|
|
||
|
|
||
| def is_embed_cached(transformer): |
There was a problem hiding this comment.
I think it'd be better to move this inside the python embed function and raise an exception if it's not cached, so we aren't grabbing the GIL from Rust twice. In the exception case, we can log, call load, and retry.
There was a problem hiding this comment.
Raise an exception? We don't want to crash pgml.embed... We are also grabbing the GIL only once, we are keeping it the entire time we're dealing with transformers.py.
There was a problem hiding this comment.
Do print statements inside transformers.py display while running pgml.embed?
There was a problem hiding this comment.
No, you need to go back to rust to print.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #616