Added random_state as an available hyper parameter for xgboost models#659
Merged
montanalow merged 1 commit intopostgresml:masterfrom May 29, 2023
SilasMarvin:set-random-seed-for-xgboost
Merged
Added random_state as an available hyper parameter for xgboost models#659montanalow merged 1 commit intopostgresml:masterfrom SilasMarvin:set-random-seed-for-xgboost
montanalow merged 1 commit intopostgresml:masterfrom
SilasMarvin:set-random-seed-for-xgboost
Conversation
montanalow
approved these changes
May 29, 2023
Contributor
|
You're right. I think the current |
montanalow
pushed a commit
that referenced
this pull request
May 31, 2023
SilasMarvin
added a commit
that referenced
this pull request
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed the standard found throughout the repo and just called
unwrapon line 166. This does have the potential to cause somewhat confusing error messages if they have malformed arguments. I would be happy to go through and replace theunwrap()calls withexpect(SOME HELPFUL ERROR MESSAGE)throughout pgml-extension if that would be helpful?