Skip to content

Conversation

@anikethsaha
Copy link
Member

This PR contains

  • Added update-notifer to notify users whenever posthtml-cli is released!

  • linting fixes using npx standard --fix

@anikethsaha
Copy link
Member Author

working on fixing the CI

@anikethsaha anikethsaha changed the title chore: added update-notifier for cli [WIP] chore: added update-notifier for cli Feb 17, 2020
@Scrum
Copy link
Member

Scrum commented Feb 18, 2020

Good idea.

Perhaps this knowledge will help make notification better.
https://github.com/posthtml/posthtml/blob/8bcf6a2cc61a216b803bc95d6e1dad7a88068a02/lib/index.js#L29-L50

Perhaps you can also cover these tasks. #74 #267

@Scrum Scrum self-requested a review February 18, 2020 07:21
@Scrum Scrum added the feat label Feb 18, 2020
@Scrum Scrum added this to the 0.6.0 milestone Feb 18, 2020
@anikethsaha
Copy link
Member Author

Perhaps this knowledge will help make notification better.
https://github.com/posthtml/posthtml/blob/8bcf6a2cc61a216b803bc95d6e1dad7a88068a02/lib/index.js#L29-L50

I didnt get this !!

update notifier will only show a banner in the CLI whenever a new version of the package comes up.
you meant to show notification for posthtml ?

@Scrum
Copy link
Member

Scrum commented Feb 18, 2020

No, I mean that you can use aggregated information in messages to display some additional information

@anikethsaha
Copy link
Member Author

No, I mean that you can use aggregated information in messages to display some additional information

Like any breaking changes or something similar ?

@Scrum
Copy link
Member

Scrum commented Feb 18, 2020

information from plugins is usually written there, you can write some kind of plugin wrapper to measure the speed of working out plugins for example.

This is the first thing that came to mind. Perhaps this is something else or maybe it does not fit at all))

@anikethsaha
Copy link
Member Author

information from plugins is usually written there, you can write some kind of plugin wrapper to measure the speed of working out plugins for example.

Actually update-notifier is specifically for notifying that there is a new version of posthtml-cli
So I think messages from plugin in update notice may not fit here.

What do you think ?

@Scrum
Copy link
Member

Scrum commented Feb 18, 2020

I think this is a good idea, definitely worth a try

@Scrum Scrum modified the milestones: 0.9.0, 0.8.0 Sep 29, 2020
@Scrum Scrum closed this in ec1305a Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants