Refactor error messages#29
Merged
Merged
Conversation
when push tag is missing name attribute value
Collaborator
|
@cossssmin thank you for this enhancements! To me looks all good. I would just change how to include From: const {get} = require('lodash');to: const get = require('lodash/get');Since according to docs and this article here this method seem to reduce bundle sizes:
I didn't test but I notice a change in bundle size after this change ecd7d54 Although there is not much to worry about the bundle size in this case. It is a fixation of mine. I will merge the PR and release by Monday the stable release if there are not any other feedback from you. Thank you! |
Member
Author
|
Sure thing, will fix it now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
<push>tag error so that it takes into account emptynameattributesLet me know what you think, thanks!