Skip to content

Support multiple tags for loopTags #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2020
Merged

Support multiple tags for loopTags #75

merged 5 commits into from
May 6, 2020

Conversation

@cossssmin
Copy link
Member

@cossssmin cossssmin commented May 2, 2020

This PR makes it possible to actually define multiple tag names for loopTags:

loopTags: ['for', 'each']
<each loop="item in array">
  {{ item }}
</each>

<for loop="item in array">
  {{ item }}
</for>

If merged, closes #74.

@coveralls
Copy link

coveralls commented May 2, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 96.939% when pulling 331f5e4 on cossssmin:master into 3e2f583 on posthtml:master.

@cossssmin cossssmin requested review from Scrum and anikethsaha May 2, 2020 16:19
anikethsaha
anikethsaha requested changes May 2, 2020
View reviewed changes
@cossssmin cossssmin mentioned this pull request May 2, 2020
Closed
anikethsaha
anikethsaha approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Scrum
Scrum requested changes May 6, 2020
View reviewed changes
@Scrum
Copy link
Member

Scrum commented May 6, 2020

@cossssmin @anikethsaha Hi guys, Sorry for taking so long

@cossssmin cossssmin requested a review from Scrum May 6, 2020 08:15
@Scrum Scrum merged commit 7b4db25 into posthtml:master May 6, 2020
@Scrum
Copy link
Member

Scrum commented May 6, 2020

@cossssmin Could you still add a description to the documentation as a separate PR?

@cossssmin
Copy link
Member Author

cossssmin commented May 6, 2020

@cossssmin Could you still add a description to the documentation as a separate PR?

Sure thing, sorry about that!

@cossssmin
Copy link
Member Author

cossssmin commented May 6, 2020

Should I also add docs for the other options, like scopeTags?

@Scrum
Copy link
Member

Scrum commented May 6, 2020

If it will not be difficult for you

@Scrum
Copy link
Member

Scrum commented May 6, 2020

@cossssmin publish v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scrum Scrum Scrum approved these changes

@anikethsaha anikethsaha anikethsaha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

loopTags not working with multiple tags

4 participants

@cossssmin @coveralls @Scrum @anikethsaha