Topic/2023.2/bug 35776#104
Merged
addabis merged 2 commits intodevelop/2023.2from Apr 28, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a naming bug by correcting the misspelled function name used to create source dependencies and makes the naming consistent throughout the file. Additionally, a TODO comment has been added to highlight potential performance issues regarding artifact downloads in public builds.
- Renames CreateSourceDependencyFromDefintion to CreateSourceDependencyFromDefinition.
- Updates all references to the corrected function name.
- Adds a TODO comment regarding filtering public builds with defined versions.
Member
|
Hello @Copilot, thank you for submitting this pull request review. We will try to get back to you as soon as possible. |
gfraiteur
approved these changes
Apr 23, 2025
gfraiteur
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.