Fix JetBrains.Annotations.NotNullAttribute for properties.

Author: Alexander Dolin

Framework/PostSharp.Samples.ResharperAnnotations/JetBrains.Annotations.cs

@@ -48,23 +48,37 @@ public IEnumerable<AspectInstance> ProvideAspects(object targetElement)
         {
             var target = targetElement;
 
-            var targetMethod = target as MethodInfo;
-
-
-            if (targetMethod != null)
+            if (target is MethodInfo targetMethod)
             {
                 if (targetMethod.IsAbstract || targetMethod.DeclaringType.Namespace.StartsWith("JetBrains."))
+                {
+                    yield break;
+                }
+                else if (targetMethod.IsSpecialName && targetMethod.Name.StartsWith("set_"))
+                {
+                    target = targetMethod.DeclaringType.GetProperty(targetMethod.Name.Substring(4),
+                        BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Static);
+                }
+                else if (targetMethod.IsSpecialName && targetMethod.Name.StartsWith("get_"))
+                {
                     yield break;
+                }
+                else
+                {
+                    target = targetMethod.ReturnParameter;
 
-                target = targetMethod.ReturnParameter;
+                }
             }
-            else
+            else if (target is ParameterInfo targetParameter)
             {
-                var targetParameter = (ParameterInfo)target;
                 var targetMember = (MethodBase)targetParameter.Member;
                 if (targetMember.IsAbstract || targetMember.DeclaringType.Namespace.StartsWith("JetBrains."))
                     yield break;
             }
+            else if (!(target is PropertyInfo))
+            {
+                yield break;
+            }
 
             yield return new AspectInstance(target, new ObjectConstruction(typeof(PostSharp.Patterns.Contracts.NotNullAttribute)), null );
         }

Framework/PostSharp.Samples.ResharperAnnotations/Program.cs

@@ -7,6 +7,9 @@ interface IProgram
 
         [JetBrains.Annotations.NotNull]
         string Foo([JetBrains.Annotations.NotNull] string bar);
+
+        [JetBrains.Annotations.NotNull]
+        string FooFoo { get; set; }
     }
 
     class Program : IProgram
@@ -33,12 +36,32 @@ static void Main(string[] args)
             {
                 Console.WriteLine(e.Message);
             }
+
+            try
+            {
+                p.FooFoo = null;
+            }
+            catch (Exception e)
+            {
+                Console.WriteLine(e.Message);
+            }
+
+            try
+            {
+                p.FooFoo = "";
+            }
+            catch (Exception e)
+            {
+                Console.WriteLine(e.Message);
+            }
         }
 
         public string Foo(string bar)
         {
             return null;
         }
+
+        public string FooFoo { get; set; }
     }