-
-
Notifications
You must be signed in to change notification settings - Fork 68
docs: mention retry plugin in tvq migration guide #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe update modifies the migration guide in the documentation by adding a new row in the API Differences section. It details that the Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for funny-banoffee-0afb46 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/cookbook/migration-tvq.md (1)
37-37: Review of the Newly Added Retry Plugin RowThe new row for
useQuery({ retry })is well integrated into the existing API Differences table. The entry clearly indicates that users should utilize the@pinia/colada-plugin-retryand follows the established format used for similar rows (e.g., the Auto Refetch plugin entry). For further clarity, you might consider adding a brief note on what the retry plugin specifically addresses or any nuances in its usage compared to the previous implementation. This additional detail could help users better understand the migration impact.
|
Of course! Glad to have more tests! |
I used the retry plugin when migrating from TanStack Query to Pinia Colada. Mentioning this difference in the migration guide might be helpful.
Additionally, I would like to write some test cases for the retry plugin. Would it be okay to submit a PR for that? Thank you!
Summary by CodeRabbit