[Bug]: Zone has not been updated successfully.

[dam2k]

Describe the problem

When I modify a TXT record and the record validation failed the only error I get is: Zone has not been updated successfully.

After debug I found that in lib/Domain/Service/Dns/RecordManager.php the failure is not handled:
251 if ($validationResult !== null && $validationResult->isValid()) {
...
275 }

There is not the else where we could add the message:
275 } else {
276 $this->messageService->addSystemError($validationResult->getFirstError());
277 }

After I added this else block I would get the real first error that is in my case:
TXT record content must be enclosed in quotes.

Steps to reproduce

Modify a TXT record without quotes

Poweradmin version

4.0.1

Database

MySQL

Additional information (optional)

No response

[michielvisser]

@dam2k I have checked this, but cannot reproduce the issue on my installation of Poweradmin (stable 4.0.1 branch). Both the creation of a TXT record and the subsequent editing works fine, both with and without quotes in the record (quotes are added automatically by Poweradmin). It works for me in both the Zone Edit page as well as editing an individual record.

Can you elaborate a little more on your test to see if this issue can be reproduced?

[dam2k]

Thank you for working on this. I double checked my DB and I reproduced the problem. I'm coming from a very old but perfectly working installation of poweradmin (v2.1.8) where the double quotes was not present on TXT records. I installed the new version of poweradmin (4.0.1) working on the old DB without double quotes on TXT record contents. In this case when you update the record you get the general error without details because of the missing "else". I'm going to update all my TXT records adding trailing and leading double quotes. Thank you.

[edmondas]

@dam2k All that case with TXT record quotes and validation is a long story. I agree that the else statement is missing, so I will add it. But regarding quotes, you can turn on auto-quoting, which might be useful in your case. Do it in the DNS block and add 'txt_auto_quote' => true.

    'dns' => [
        ...
        'txt_auto_quote' => true
    ]