This repository was archived by the owner on Mar 11, 2019. It is now read-only.
feature(v4.0): refactoring #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utomatically created anymore A Clock for producing periodic ticks is created only when the "every(frequency)" method is called on a PowerMonitoring object. It allows then to have external ticks when needed. Sensors, formulae and reporters have now their own Supervisor, and each component actor is now responsible to handle one target at a time. Two reporters are not refactored yet (Rest, Fuse). refactor(tests): improve the coverage, and clean tests Several tests have been rewritten and cleaned. The coverage is now up to more than 70%. refactor(examples): change the external dependency to a local one The examples were written to use PowerAPI as en external dependency. The dependency is now local (PowerAPIBuild), and allows to get the examples up-to-date with the powerapi-core library.
This feature adds an InfluxDB display, using the standard java API.
Use travis for building docker images on tags and publish releases. Closes #77
feature(v4.0): refactoring
mcolmant
force-pushed
the
develop
branch
3 times, most recently
from
32db677 to
a0b2161
Compare
| case "--frequency" :: value :: tail if validate(durationR, value) => | ||
| cliMonitorsSubcommand(options, currentMonitor ++ Map('frequency -> value), tail) | ||
| case "--self" :: tail => | ||
| cliMonitorsSubcommand(options, currentMonitor + ('targets -> (currentMonitor.getOrElse('targets, Set[Any]()).asInstanceOf[Set[Any]] + Process(ManagementFactory.getRuntimeMXBean.getName.split("@")(0).toInt))), tail) |
There was a problem hiding this comment.
[Scalastyle] WARNING: File line length exceeds 160 characters
| if (divisor.isInfinite || divisor.isNaN) throw new IllegalArgumentException("divisor must be a finite and defined value") | ||
| else safeMul(value / divisor) | ||
| }, unit | ||
| if (divisor.isInfinite || divisor.isNaN) throw new IllegalArgumentException("divisor must be a finite and defined value") |
There was a problem hiding this comment.
[Scalastyle] WARNING: If block needs braces
| def toKiloWatts(p: Double) = p/(C2/C0) | ||
| def toMegaWatts(p: Double) = p/(C3/C0) | ||
|
|
||
| def toWatts(p: Double) = p / (C1 / C0) |
There was a problem hiding this comment.
[Scalastyle] WARNING: Public method must have explicit type
…onatype repository and update the changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each base component has now is own supervisor, a Clock is not started automatically anymore (allows to have external "ticks", a new display for InfluxDB was written.
Travis-ci is now used to publish automatically the artefacts when a tag is created.